Repository navigation
ENH: Migrate to CMake 3.23+ FILE_SET for header management - #2502
Merged
Merged
Conversation
blowekamp
commented
Jan 13, 2026
blowekamp
commented
Member
- Raise minimum CMake version to 3.23.0
- Use target_sources() with FILE_SET HEADERS for automatic include directory management
- Remove manual target_include_directories() and install() commands for headers
- Consolidate CMakeLists from src/ subdirectories into module root
- Add PRIVATE file sets for internal headers (better IDE support)
- Simplifies header installation and build interface configuration
blowekamp
force-pushed
the
cmake_fileset
branch
2 times, most recently
from
January 13, 2026 18:34
a394542 to
729a4cf
Compare
Member
Author
|
The Explicit and the ElastixTransformixWrappers directories also needs to be updated. |
blowekamp
force-pushed
the
cmake_fileset
branch
2 times, most recently
from
January 16, 2026 23:46
0c7a85b to
32cb344
Compare
- Raise minimum CMake version to 3.23.0 - Use target_sources() with FILE_SET HEADERS for automatic include directory management - Remove manual target_include_directories() and install() commands for headers - Consolidate CMakeLists from src/ subdirectories into module root - Add PRIVATE file sets for internal headers (better IDE support) - Simplifies header installation and build interface configuration
blowekamp
force-pushed
the
cmake_fileset
branch
from
January 20, 2026 15:19
32cb344 to
410494d
Compare
dave3d
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.