Repository navigation
ENH: Simplify ccache key in Build.yml GHA workflow - #2573
Merged
Merged
Conversation
The branch-name embedding in the cache key was redundant. GHA cache scoping already searches the current branch first, then falls back to the default branch (main), so a PR naturally restores the latest main ccache via the prefix restore-key without needing branch names encoded in the key string.
blowekamp
marked this pull request as ready for review
April 29, 2026 15:40
zivy
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ccache
keyandrestore-keyswere encoding branch names (github.head_ref,github.base_ref,github.ref_name) to try to create a branch-preference fallback order. This is unnecessary.GHA cache scoping already handles this natively: restore-keys are searched on the current branch first, then the default branch (
main), and for PRs also the base branch. A PR therefore naturally falls back to the latestmainccache via the simple prefixccache-v1-{name}-, with no branch names needed in the key.Change