Repository navigation
COMP: Remove KWStyle style checking - #2578
Merged
Merged
Conversation
KWStyle support was added in 2010 but has never been actively used. The project now uses clang-format (via pre-commit) for C++ style enforcement, making KWStyle fully redundant. Remove: - Utilities/KWStyle/ directory and all its files - The unconditional include() of KWStyle.cmake in CMakeLists.txt - The hooks.style=KWStyle,uncrustify attribute from .gitattributes
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy KWStyle-based style checking infrastructure from the build and repository metadata, aligning style enforcement with the existing clang-format + pre-commit workflow.
Changes:
- Remove
Utilities/KWStyle/(KWStyle config/templates and the CMake integration module). - Stop including
Utilities/KWStyle/KWStyle.cmakefrom the top-levelCMakeLists.txt. - Remove
hooks.style=KWStyle,uncrustifyattributes from.gitattributes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Utilities/KWStyle/SITKOverwrite.txt |
Removes KWStyle overwrite configuration. |
Utilities/KWStyle/SITKFiles.txt.in |
Removes KWStyle file list template. |
Utilities/KWStyle/SITK.kws.xml.in |
Removes KWStyle XML rules template. |
Utilities/KWStyle/KWStyle.cmake |
Removes KWStyle discovery/configuration and related targets/tests. |
CMakeLists.txt |
Removes unconditional KWStyle include from the build. |
.gitattributes |
Drops KWStyle/uncrustify style hook attributes for C/C++ extensions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dave3d
approved these changes
Apr 30, 2026
zivy
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KWStyle support was added in 2010 but has never been actively used. The project now uses clang-format (via pre-commit) for C++ style enforcement, making KWStyle fully redundant.
Changes
Utilities/KWStyle/directory and all its filesinclude()ofKWStyle.cmakefromCMakeLists.txthooks.style=KWStyle,uncrustifyattribute from.gitattributesNote: The
ITK_USE_KWSTYLE=OFFflags in the SuperBuild and FetchContent ITK configurations are intentionally kept, as ITK itself still supports KWStyle and we want to ensure it is disabled when building ITK as a dependency.