Repository navigation
ENH: Add R wrapping CI coverage to Build and BatchBuild workflows - #2586
Merged
Merged
Conversation
- Add DEFAULT_R_VERSION and DEFAULT_PYTHON_VERSION top-level env defaults - Add WRAP_R to to more builds - Install argparser R package as part of build dependencies when WRAP_R
Out-of-line = default caused only the C2 (base object) constructor to be emitted since LoggerBase is abstract. The R SWIG wrapper compiles with SWIGR defined, making LoggerBase concrete and requiring C1, which was missing. Inlining the constructor in the header fixes the dlopen error.
blowekamp
marked this pull request as ready for review
May 7, 2026 17:31
dave3d
approved these changes
May 7, 2026
zivy
approved these changes
May 7, 2026
| cmake-build-type: "Release" | ||
| cmake-generator: "Ninja" | ||
| apt-get-dependencies: "liblua5.3-dev lua5.3" | ||
| r-version: "4.0" |
Member
There was a problem hiding this comment.
Any reason for using this old of a version? Possibly use three minor versions back from current 4.6, so 4.3?
Member
Author
There was a problem hiding this comment.
That is what swig was experimenting with as the old supported version. The most recent 3 versions is also reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.