Repository navigation
ENH: Add NoMask test case for NormalizedCorrelationImageFilter - #2634
Merged
blowekamp merged 1 commit intoJul 20, 2026
Merged
Conversation
Mark MaskImage as optional in the YAML and add a test that exercises the null-mask code path in itk::NormalizedCorrelationImageFilter (see SimpleITK#2625, S34).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SimpleITK wrapping definition for itk::NormalizedCorrelationImageFilter so that a mask image is truly optional in the generated wrapped API, and adds a corresponding test/baseline to exercise ITK’s explicit “null mask” code path.
Changes:
- Marked
MaskImageasoptional: trueinNormalizedCorrelationImageFilter.yamlto generate a maskless overload. - Added a
NoMaskYAML-driven test case that supplies only the required inputs (image + template). - Added the corresponding ExternalData SHA512 baseline entry for the new test output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Code/BasicFilters/yaml/NormalizedCorrelationImageFilter.yaml |
Makes MaskImage optional and adds a NoMask test that omits the mask input. |
Testing/Data/Baseline/BasicFilters_NormalizedCorrelationImageFilter_NoMask.nrrd.sha512 |
Adds the baseline hash for the new NoMask test output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dave3d
approved these changes
Jul 16, 2026
zivy
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #2625, item S34.
itk::NormalizedCorrelationImageFilterhas an explicit null-mask branch (.hxx:167-198), but the SimpleITK YAML did not declareMaskImageasoptional: true, so no maskless overload was ever generated and that code path was untested through the wrapped API.This PR:
MaskImageasoptional: trueinNormalizedCorrelationImageFilter.yaml.NoMasktest case that calls the filter without a mask image, exercising the null-mask branch.Testing/Data/Baseline/BasicFilters_NormalizedCorrelationImageFilter_NoMask.nrrd.sha512); the binary object has been uploaded to theSimpleITKExternalDatarepository.