Skip to content

This PNG when converted to WebP by ImageSharp produces a corrupted WebP file #2068

Description

@rwasef1830

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of ImageSharp
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

ImageSharp version

2.1.0

Other ImageSharp packages and versions

ImageSharp.Web 2.0.0-alpha.0.18

Environment (Operating system, version and so on)

Windows 10

.NET Framework version

.NET 6.0.3

Description

The attached image when converted to WebP at default quality, produces a file that doesn't render in any browser and is deemed as corrupt.

Steps to Reproduce

Use standard ImageSharp.Web middleware to request conversion of the attached image to webp. The corrupt webp is also attached.

Thanks for the awesome library.

Images

nuclear

corrupted webp output (inside zip):
converted.zip

Other pngs convert fine.

Activity

  1. rwasef1830 commented on Mar 21, 2022

    @rwasef1830
    Author

    Just in case there's any conversion by GitHub (the source image in zip file):
    nuclear.zip

  2. JimBobSquarePants commented on Mar 21, 2022

    @JimBobSquarePants
    Member

    Can you please run a test using ImageSharp as a standalone? There’s no published version of Web (not even alphas) built against 2.1.0 yet.

  3. rwasef1830 commented on Mar 21, 2022

    @rwasef1830
    Author

    oh, standalone it produces a correct file! Maybe it's some memory corruption due to mismatch between the web middleware and the main library. Ok, I mistakenly thought this case should work owing to semantic versioning. My apologies.

    @JimBobSquarePants

  4. JimBobSquarePants commented on Mar 21, 2022

    @JimBobSquarePants
    Member

    I’ll double check my local web build anyway. I have a PR in motion that will bring direct support.

  5. JimBobSquarePants commented on Mar 21, 2022

    @JimBobSquarePants
    Member

    On versioning yeah…. We had to introduce a breaking change due to some IO blocking in our async workflow.

  6. JimBobSquarePants commented on Mar 21, 2022

    @JimBobSquarePants
    Member

    image

    Just to confirm, here's my local build working well. I'm working hard to get a release out asap.

  7. rwasef1830 commented on Mar 21, 2022

    @rwasef1830
    Author

    @JimBobSquarePants I was able to isolate the issue, it was a bug in my file provider. There's no issue in ImageSharp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions