Added support for image integral computation. by rold2007 · Pull Request #1536 · SixLabors/ImageSharp

rold2007 · 2021-02-07T05:06:41Z

Prerequisites

I have written a descriptive pull-request title
I have verified that there are no overlapping pull-requests open
I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
I have provided test coverage for my change (where applicable)

Description

This pull request replaces this one.

…/ImageSharp into tkp1n/avx2-color-converter

3 <==> 4 Channel Shuffling with Hardware Intrinsics

…/ImageSharp into tkp1n/avx2-color-converter

Vectorize (AVX2) JPEG Color Converter

…1416

…ence output

Fix for Issue 1416

Sanitize Gif descriptor bounds.

JpegEncoder - Optimize Some Low Hanging Fruit

Better JpegEncoder profiling & benchmarks

ghost · 2021-02-07T06:13:50Z

Codecov Report

Merging #1536 (ce86962) into master (8e21937) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
+ Coverage   83.47%   83.49%   +0.01%     
==========================================
  Files         742      743       +1     
  Lines       32830    32856      +26     
  Branches     3667     3670       +3     
==========================================
+ Hits        27406    27432      +26     
  Misses       4709     4709              
  Partials      715      715

Flag	Coverage Δ
unittests	`83.49% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ocessing/Extensions/Transforms/ImagingUtilities.cs	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e21937...ce86962. Read the comment docs.

ghost

Looks good. Thanks for resubmitting after I messed up!

Just some minor organizations changes, the code looks good 👍

ghost · 2021-02-09T04:52:26Z

+    /// <summary>
+    /// Defines extensions that allow the computation of image integrals on an <see cref="Image"/>
+    /// </summary>
+    public static class ImagingUtilities


The only thing I would change is to make the existing ProcessingExtensions partial and rename this one to match. ProcessingExtensions.IntegralImage.cs. I'd also move it to the same Processing/Extensions/ folder.

ghost · 2021-02-09T04:54:07Z

+    public static class ImagingUtilities
+    {
+        /// <summary>
+        /// Apply an image integral. See https://en.wikipedia.org/wiki/Summed-area_table


You can use <see href="/api/browser/proxy?url=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FSummed-area_table"/> to better work with intellisense docs.

ghost · 2021-02-09T04:55:14Z

+using SixLabors.ImageSharp.Processing;
+using Xunit;
+
+namespace SixLabors.ImageSharp.Tests.Processing.Transforms


Move to tests/ImageSharp.Tests/Processing/ and rename class.

ghost · 2021-02-17T01:46:16Z

Sorry @rold2007

We just added Git LFS to the repository and it's rewritten the history. This has forced the PR to be closed and I cannot reopen it.

If you like I can create a new PR based upon your work to save you the effort of redoing it?

ghost · 2021-02-17T12:17:55Z

@JimBobSquarePants No worries. I'll open a new PR myself.

ghost · 2021-02-17T12:21:47Z

Thanks @rold2007 !!

James Jackson-South and others added 30 commits November 6, 2020 20:45

Fix shuffle

3cda066

Merge branch 'master' into tkp1n/avx2-color-converter

c7a7b50

Respond to Anton fedback

8212e60

Merge branch 'tkp1n/avx2-color-converter' of https://github.com/tkp1n…

7ecfab7

…/ImageSharp into tkp1n/avx2-color-converter

Merge pull request #1409 from SixLabors/js/Shuffle3Channel

9f51a92

3 <==> 4 Channel Shuffling with Hardware Intrinsics

Merge branch 'master' into pixel-swizzle

3dc2209

Merge branch 'master' into tkp1n/avx2-color-converter

c0ad228

Add missing conditional

7a3bdf3

Merge branch 'tkp1n/avx2-color-converter' of https://github.com/tkp1n…

da732b7

…/ImageSharp into tkp1n/avx2-color-converter

Micro-optimize grayscale converter

8f5ae2d

Remove useless branch

0aa3ba5

Merge pull request #1411 from tkp1n/tkp1n/avx2-color-converter

b37044f

Vectorize (AVX2) JPEG Color Converter

Use Interlocked.Increment during histogram calculation, fixes issue #…

274cabf

…1416

Add global histogram equalization test which compares result to refer…

5c8f66c

…ence output

Add unowned Image.WrapMemory(void*) overloads

32a2f6d

Add pointer null check on construction

aa0c0aa

Add unit tests for WrapMemory(void*) overloads

0f7926f

Use Interlocked.Increment(ref Unsafe.Add(ref histogramBase, luminance));

ae27c04

Merge pull request #1418 from SixLabors/bp/Issue1416

abc1573

Fix for Issue 1416

Add new property and implement for TPixel types

686aef7

Update External

181d434

Fix Short4 and tests

842cd37

Remove bas T4 refs

f30e22f

Don't autogenerate GetPixelTypeInfo

e18ef9f

Add support using libgdiplus on macOS

427d97a

Fix incompatible package reference for OSX

c44690f

Move package to build props

8f2da28

Do not run windows specific tests on macOS

2085b77

Decorate OSX specific tests

1763949

Use bulk conversion to rgba in Write8BitColor

247834f

James Jackson-South and others added 21 commits February 2, 2021 17:25

Santize descriptor bounds. Fixes #1530

ba115e1

Merge pull request #1532 from SixLabors/js/fix-1530

edff37d

Sanitize Gif descriptor bounds.

Merge branch 'master' into js/jpeg-encoder-perf

9d74ef4

Update RowOctet tests

5398b40

Remove bounds checks during Emit

2a4b696

Add AVX Block8x8F.DivideRoundAll

f3baa34

Fix typo

7e37d3d

Remove compiler conditional for static fields

dee1bfc

Disable inlining

ca56515

manually inline meythod

3ff1c27

Try explicit layout

a1042ce

Move statics to local

f87b38c

Update Block8x8F.cs

6f367ca

Use a loop instead.

aa8dcd9

Cleanup

14226ce

Optimize and fix warnings.

461e59d

Merge pull request #1533 from SixLabors/js/jpeg-encoder-perf

27135a0

JpegEncoder - Optimize Some Low Hanging Fruit

better JpegEncoder profiling/benchmarks

9088d7e

change inlining options for RowOctet.Update()

4bd6c04

Merge pull request #1534 from SixLabors/af/JpegEncoder-profiling

8e21937

Better JpegEncoder profiling & benchmarks

Added support for image integral computation.

ce86962

JimBobSquarePants requested changes Feb 9, 2021

View reviewed changes

rold2007 mentioned this pull request Feb 11, 2021

Added support for image integral computation. #1441

Closed

4 tasks done

JimBobSquarePants closed this Feb 17, 2021

JimBobSquarePants force-pushed the master branch from db51f69 to 172c48e Compare February 17, 2021 01:43

rold2007 mentioned this pull request Feb 18, 2021

Added image integral algorithm. #1561

Merged

4 tasks done

Navigation Menu

Repository navigation

Added support for image integral computation. - #1536

Added support for image integral computation.#1536
rold2007 wants to merge 8934 commits into
SixLabors:masterfrom
rold2007:ImageIntegral

rold2007 commented Feb 7, 2021

Uh oh!

ghost commented Feb 7, 2021

Uh oh!

ghost left a comment

Uh oh!

ghost Feb 9, 2021

Uh oh!

ghost Feb 9, 2021

Uh oh!

ghost Feb 9, 2021

Uh oh!

ghost commented Feb 17, 2021

Uh oh!

ghost commented Feb 17, 2021

Uh oh!

ghost commented Feb 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

rold2007 commented Feb 7, 2021

Prerequisites

Description

Uh oh!

ghost commented Feb 7, 2021

Codecov Report

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

ghost Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

ghost Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

ghost commented Feb 17, 2021

Uh oh!

ghost commented Feb 17, 2021

Uh oh!

ghost commented Feb 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants