Skip to content

Add Tiff format to the default Configuration - #1634

Merged
JimBobSquarePants merged 1 commit into
masterfrom
bp/AddTiffToDefaultConfig
May 26, 2021
Merged

JimBobSquarePants merged 1 commit into
masterfrom
bp/AddTiffToDefaultConfig

Conversation

@brianpopow

Copy link
Copy Markdown
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR will add the TIFF format to the default Configuration.

@brianpopow brianpopow added this to the 1.1.0 milestone May 26, 2021
@codecov

codecov Bot commented May 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1634 (2e87f7a) into master (d3775d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1634   +/-   ##
=======================================
  Coverage   84.08%   84.09%           
=======================================
  Files         813      812    -1     
  Lines       35598    35594    -4     
  Branches     4144     4144           
=======================================
- Hits        29933    29931    -2     
+ Misses       4844     4843    -1     
+ Partials      821      820    -1     
Flag Coverage Δ
unittests 84.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Configuration.cs 100.00% <100.00%> (ø)
...ImageSharp/Formats/Tiff/TiffImageFormatDetector.cs 85.71% <0.00%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3775d7...2e87f7a. Read the comment docs.

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JimBobSquarePants
JimBobSquarePants merged commit a7f6632 into master May 26, 2021
@JimBobSquarePants
JimBobSquarePants deleted the bp/AddTiffToDefaultConfig branch May 26, 2021 08:57
@brianpopow brianpopow mentioned this pull request May 26, 2021
16 of 25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants