Repository navigation
Remove #nullable disable from ExifProfile - #2320
Merged
JimBobSquarePants merged 9 commits intoJan 26, 2023
Merged
JimBobSquarePants merged 9 commits into
JimBobSquarePants merged 9 commits into
Conversation
stefannikolei
commented
Jan 17, 2023
stefannikolei
commented
Jan 17, 2023
| public override ExifDataType DataType => ExifDataType.Byte; | ||
|
|
||
| protected override string StringValue => this.Value; | ||
| protected override string? StringValue => this.Value; |
Contributor
Author
There was a problem hiding this comment.
After looking through the changes, I think I wasn't consistent with this override. Should I add the ? in all ExifValue types?
Contributor
Author
There was a problem hiding this comment.
Ok compiler tells me that it can be removed in the other places
stefannikolei
marked this pull request as ready for review
January 18, 2023 07:45
4 tasks done
| int tileLength = (int)tags.GetValue(ExifTag.TileLength).Value; | ||
| if (!tags.TryGetValue(ExifTag.TileWidth, out IExifValue<Number> valueWidth)) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(valueWidth); |
Member
There was a problem hiding this comment.
This should be an InvalidImageContentException
* Throw InvalidImageContentException * Change GetDesctiption to TryGetDescription * Do not throw when creating exifvalue and adding it to ifdValues
JimBobSquarePants
added
API
codequality
breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Resolves the nullable issues in the ExifProfile space #2231
@JimBobSquarePants Do you think we can tackle it like that, or do you have other opinions how we could/should do it?
I had a bit of a struggle with the Generic TValueType. I tried to introduce
were TValueType : struct. But there are cases whereTValueType = string--> zonkI added an InvalidOperationException to 'private static Encoding JIS0208Encoding' to not expose Encoding? because that will never happen. What do you think about this? Wanna go this way or should I add an ! here to dismiss the warning