Repository navigation
#2231 First steps for removing nullable disable in webp - #2364
Conversation
| if (this.pos < this.bufferMax) | ||
| { | ||
| ulong inBits = BinaryPrimitives.ReadUInt64LittleEndian(this.Data.Memory.Span.Slice((int)this.pos, 8)); | ||
| ulong inBits = BinaryPrimitives.ReadUInt64LittleEndian(this.Data!.Memory.Span.Slice((int)this.pos, 8)); |
There was a problem hiding this comment.
There's some horrible temporal coupling here. I don't think the correct fix would be to add !. It may require much deeper refactoring.
There was a problem hiding this comment.
Yeah probably. And there are some more classes where it is not so easy to remove the #nullable disable
There was a problem hiding this comment.
I'm gonna be looking at some optimization opportunities in those classes. I think we should leave this until that is done.
We've covered all the public bits now anyway I think?
There was a problem hiding this comment.
ok I tried to ref it. Can you have a look?
There was a problem hiding this comment.
There was a problem hiding this comment.
ok I tried to ref it. Can you have a look?
Ah nice, will do!
There was a problem hiding this comment.
Refactor looks good. I just pushed some additional cleanup.
There was a problem hiding this comment.
Actions seems to be having a wobble. I'll merge in the morning.
2 participants
Prerequisites
Description
#2231 Remove nullable disable from some classes in the webp format