Repository navigation
Fix for #576, using explicit struct layout for bgr24 and rgb24 - #591
Merged
Merged
Conversation
4 tasks done
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
==========================================
+ Coverage 88.73% 88.78% +0.04%
==========================================
Files 854 854
Lines 36172 36172
Branches 2620 2620
==========================================
+ Hits 32099 32114 +15
+ Misses 3290 3275 -15
Partials 783 783
Continue to review full report at Codecov.
|
antonfirsov
approved these changes
May 24, 2018
antonfirsov
left a comment
antonfirsov
left a comment
Member
There was a problem hiding this comment.
Unksipped CloneAs_ToBgr24. We should merge this, if the build succeeds,
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR addresses to fix the issue that ImageCloneTests.CloneAs_ToBgr24() was failing sporadically.
rgb24 struct was also changed, because it may also be affected by this issue.