Repository navigation
Use correct Kernel dimensions and optimize. Fix #786 - #789
Conversation
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
Haven't gone too deep, but looks good at first look.
We should probably add at least one reference-image based test case to ensure correctness, with a reference image generated by CSS.
@antonfirsov I would but CSS blur over-samples past the edge of the image so we can't compare. Additionally we use a constrained kernel when sampling, capturing 97% of the Gaussian integral but ignoring changes generally invisible to the human eye when compared to an infinite kernel. |
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
- Coverage 88.7% 88.66% -0.04%
==========================================
Files 1012 1012
Lines 43248 43222 -26
Branches 3127 3120 -7
==========================================
- Hits 38363 38324 -39
+ Misses 4181 4160 -21
- Partials 704 738 +34
Continue to review full report at Codecov.
|
2 participants
Prerequisites
Description
Our current gaussian kernels are too small and fail to capture the full curve leading to boxed output. I've updated the algorithm based on the information found at http://chemaguerra.com/gaussian-filter-radius/ to correct the output.