Repository navigation
#946: AoT compiler fixes and cleaned up AoTCompilerTools - #949
Merged
Merged
Conversation
Update from SixLabors/ImageSharp
antonfirsov
reviewed
Jul 19, 2019
antonfirsov
left a comment
antonfirsov
left a comment
Member
There was a problem hiding this comment.
You are a true hero, thanks a lot! 🎉
A few minor changes needed to make StyleCop happy though. (Normally, your local environment should report these warnings as errors on release builds.)
| private static void AotCompileResizeOperations<TPixel>() | ||
| where TPixel : struct, IPixel<TPixel> | ||
| { | ||
| var resizeProcessor = new ResizeProcessor(new ResizeOptions(), new Size()); |
Member
There was a problem hiding this comment.
new ResizeProcessor(new ResizeOptions(), default) should do the job.
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
=========================================
- Coverage 89.67% 89.5% -0.18%
=========================================
Files 1086 1085 -1
Lines 47777 47808 +31
Branches 3362 3362
=========================================
- Hits 42846 42791 -55
- Misses 4245 4325 +80
- Partials 686 692 +6
Continue to review full report at Codecov.
|
Member
|
I'm merging this, we can do the rest of #946 in follow-up PR-s. |
Member
|
Thanks so much for your help here @dmanning23 !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
These changes update the AoTCompilerTools to fix a few issues with the iOS build.
I've verified that jpeg, gif, and resizing work on iOS with these changes.