Repository navigation
Refactor SEG-Y ingestion pipeline into general modular components - #823
Merged
Merged
Conversation
* Introduce a new `dataset_factory` module for schema-driven dataset creation. * Implement `run_segy_ingestion` orchestrator to streamline SEG-Y ingestion. * Enhance dataset templates with dimension specification methods to ensure consistency in data types. * Update `__init__.py` files to include new ingestion components and improve module organization. * Remove deprecated `schema_resolver.py` to clean up the codebase. * Add unit tests to validate new functionalities and ensure robustness.
Co-authored-by: Cursor <[email protected]>
…bulary and requirements up the hierarchy
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
==========================================
+ Coverage 85.30% 92.99% +7.68%
==========================================
Files 46 143 +97
Lines 2219 8163 +5944
Branches 306 463 +157
==========================================
+ Hits 1893 7591 +5698
- Misses 281 498 +217
- Partials 45 74 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BrianMichell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor retains a thin shim for legacy code support to allow for gradual phase-out of old code paths.
Modernizes the pipeline to avoid runtime template mutation via side-effects and implements a runtime factory instantiation.
Generalizes ingestion pipeline architecture for easier format extensibility.
Replace monolithic GridOverrider with compostable IndexStrategies.