Repository navigation
Missing Edge Case for odd_even_transposition_parallel.py #10925
Description
Repository commit
Python version (python --version)
3.11.6
Dependencies version (pip freeze)
Only default libraries used in this file
Expected behavior
When creating tests for this file I found a bug. Creating a list with 0 to 11 (or higher) in reverse leads to odd behavior. However, creating a list from 0 to 10 and 0 to 5 seems to work.
odd_even_transposition(list(range(11)[::-1])) outputs
[1, 0, 3, 2, 5, 4, 7, 6, 9, 8, 10]
Actual behavior
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
Activity
ufraaan commentedon Oct 25, 2023
maybe try
sorted_lst = sorted(lst)
print(sorted_lst)
RaymondDashWu commentedon Oct 25, 2023
Hi @ufraan, I'm not sure what you're referring to. The code you provided would output a sorted list but the error is in the algorithm's implementation.
RaymondDashWu commentedon Oct 25, 2023
It occurs to me that this may be an issue with how M1 Macs handle multiprocessing based on this:
https://stackoverflow.com/questions/65859890/python-multiprocessing-with-m1-mac
Can anyone confirm if
odd_even_transposition(list(range(11)[::-1]))works as expected?bhavesh1oo commentedon Oct 25, 2023
I ran the odd_even_transposition(list(range(11)[::-1])) test case and it is giving the output
Sorted List
1 0 3 2 5 4 7 6 9 8 10
hoarffrost commentedon Oct 25, 2023
Hey, @RaymondDashWu , I just found what is the problem with this algorithm, so can you please assaign me this issue. Thank you...✌️
RaymondDashWu commentedon Oct 25, 2023
Awesome @gyan313 ! Issues aren't assigned in this repo so feel free to just make a PR.
hoarffrost commentedon Oct 26, 2023
Hey, @RaymondDashWu , I just opened a pr #10976 , can you review that please❤️...Thanks
RaymondDashWu commentedon Oct 26, 2023
Ah I didn't realize there was a hard coded range(10) in there. Nice catch! I'm not a maintainer though so I won't be the one merging the PR.
RaymondDashWu commentedon Oct 27, 2023
Marking this as closed since a PR has been made containing the fix