Repository navigation
Fix matrix binary search missing values at row starts - #15560
Open
Miladkhoshdel wants to merge 2 commits into
Open
Miladkhoshdel wants to merge 2 commits into
Miladkhoshdel wants to merge 2 commits into
Conversation
12 of 15 tasks
4 of 12 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Fix
mat_bin_search()missing a target that equals the first element of a row after the first row.For example,
mat_bin_search(3, [[1, 2], [3, 4]])previously returned[-1, -1]instead of[1, 0].The row-selection loop used
<, stopping before searching a row whose first element equaled the target. Changing the condition to<=allows that row to be searched.This PR changes one condition in one algorithm file. Existing doctests remain unchanged.
Validation:
git diff --checkpassed.Checklist