Repository navigation
Conversation
… are standard and do not need documentation
|
i also ran my formatter, please let me know if i should revert it |
dhruvmanila
left a comment
There was a problem hiding this comment.
Thanks for doing this. I completely forgot that we had a reason to not skip those dunder methods, but it makes sense to skip them. What do you say? @cclauss
Also, what formatter did you run? It changed a few things in a not so good way lol. We use pre-commit so if you enable it, you can just forget about the formatting part ;)
|
My sense is that some dunder methods should be tested like |
|
Makes sense. |
|
BTW the formatter is default Pycharm |
|
Or actually, when rethinking it, the equality methods maybe should also have docstrings |
|
PyCharm does not come from the Python Software Foundation but psf/Black does. |
|
Decided to close, this solution needs more thinking |
nothing much to add, part of TheAlgorithms/Python#4352