Repository navigation
tools/run_tests.sh and run_tests.bat never actually put JOGL on the classpath (dead CLS_PATH variable) #7
Description
Activity
Verified against current HEAD (coverage/phase1-value-objects-phase2-handlers branch): both
tools/run_tests.shandtools/run_tests.batalready buildCLS_PATH/%CLS_PATH%with the JOGL jars explicitly enumerated (not glob-referenced) and pass it to-cp, matching exactly the fix this issue describes as landed in #2.run_tests.sh:CLS_PATH="$OUT_PATH" for jar in "${DIR}"/third_party/jogamp/jar/*.jar; do CLS_PATH="${jar}:${CLS_PATH}" done ... java ... -cp "$CLS_PATH" --select-package tests.junittests "$@"run_tests.bathas the equivalentfor %%f in (...) do set CLS_PATH=...pattern. Closing as already fixed.
Summary
Both
tools/run_tests.shandtools/run_tests.batbuild aCLS_PATH/%CLS_PATH%variable that includes the JOGL jars (third_party/jogamp/jar/*), but the actualjavainvocation only ever passed$OUT_PATH/%OUT_PATH%to-cp--CLS_PATHwas computed and then never used. Separately, even fixing that naively hits a second issue:-jarand-cptogether mean the JVM's own classpath handling is bypassed (the JUnit console launcher parses its own-cp/--class-pathargument instead), and that parser does not expand a trailing/*into a jar list the way the realjavalauncher's-cpdoes -- so the jars have to be listed explicitly, not glob-referenced.Impact
Any OSR-based JUnit test fails with
NoClassDefFoundError: com/jogamp/opengl/awt/GLCanvaswhen run via the official script, sinceorg.cef.browser.CefBrowserFactoryneeds JOGL classes for OSR (CefBrowserOsr). This presumably went unnoticed because no OSR-based JUnit test existed until this fork added one (OsrSmokeTest, see #2) -- the existing tests (DisplayHandlerTest,DragDataTest,TestFrameTest) all used windowed mode, which doesn't need JOGL.Fix (in #2)
Explicitly enumerate the jars from
third_party/jogamp/jar/*.jarinto the classpath string passed to-cp, in both scripts.