Skip to content

copy-paste bug in bind smf start method #189

Description

@isaacdavis

In the start method for the bind SMF service, this line appears to have been copy-pasted from the case statement immediately above it. The -t flag should be removed -- the line should instead read:

 checkopts="${checkopts} ${value}"

This error also exists in bind versions 9.11 and 9.12.

We're now using bind (version 9.10.7) in the triton-prometheus image, which uses https://pkgsrc.joyent.com/packages/SmartOS/2018Q1/multiarch/All, so it would be excellent if this fix could be backported there as well. Thank you!

Activity

  1. jperkin commented on Jun 19, 2019

    @jperkin
    Collaborator

    Thanks, sorry it's taken so long to integrate this. I can't backport to 2018Q1 as it's long out of support, but I will backport these to 2018Q4.

  2. self-assigned this
    on Jun 19, 2019
  3. jperkin commented on Jun 20, 2019

    @jperkin
    Collaborator

    These have been backported to 2018Q4 along with a bunch of the latest security fixes. I'm now running the backported bind-9.12.4pl2 on my personal server and it appears to be working fine.

  4. isaacdavis commented on Jun 21, 2019

    @isaacdavis
    Author

    Thanks, Jonathan! This is very helpful.

  5. added a commit that references this issue on Aug 26, 2019
  6. added a commit that references this issue on Nov 6, 2019
  7. added a commit that references this issue on Dec 15, 2019
  8. added a commit that references this issue on Mar 7, 2020
    95c1104
  9. 109 remaining items

  10. added a commit that references this issue on Jul 27, 2026
  11. added a commit that references this issue on Aug 7, 2026
  12. added a commit that references this issue on Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions