Skip to content

unbound build fails due to include file issue and missing dependency #286

Description

@drboone

Preface: I'm very not clued in on pkgsrc practices.

The unbound build is currently failing for smartos-trunk. I think there are two issues:

  1. I can't find a dependency for nghttp2 (maybe I don't understand the makefile structure properly?). Configure fails because its library and include files are not installed. Adding a simple DEPENDS+= nghttp2 line in the Makefile seems to address this error. Not sure what the canonical packaging should look like here.
checking for libnghttp2... configure: error: Could not find libnghttp2, nghttp2.h
*** Error code 1

Stop.
bmake[1]: stopped in /data/jenkins/workspace/pkgsrc-upstream-trunk/net/unbound
*** Error code 1

Stop.
bmake: stopped in /data/jenkins/workspace/pkgsrc-upstream-trunk/net/unbound
  1. services/listen_dnsport.c doesn't seem to include limits.h any way I can find, but the SSIZE_MAX definition is there. Just adding a simple #include <limits.h> fixes that compile phase error. Not sure if this should be wrapped in ifdefs or something.
--- listen_dnsport.lo ---
./services/listen_dnsport.c: In function 'http2_submit_response_read_callback':
./services/listen_dnsport.c:2129:15: error: 'SSIZE_MAX' undeclared (first use in this function); did you mean 'SIZE_MAX'?
 2129 |  if(copylen > SSIZE_MAX)
      |               ^~~~~~~~~
      |               SIZE_MAX
./services/listen_dnsport.c:2129:15: note: each undeclared identifier is reported only once for each function it appears in
*** [listen_dnsport.lo] Error code 1

bmake: stopped in /home/pbulk/build/net/unbound/work/unbound-1.12.0

Any chance you folks could turn the above notes into proper pkgsrc and implement?

Activity

  1. added a commit that references this issue on Nov 26, 2020
  2. self-assigned this
    on Dec 4, 2020
  3. jperkin commented on Dec 4, 2020

    @jperkin
    Collaborator

    Hey, sorry I didn't respond to this ticket earlier, both of these issues have since been fixed and there should be a working unbound package available in trunk again.

  4. added a commit that references this issue on Jun 15, 2021
  5. added a commit that references this issue on Jan 24, 2022
  6. added a commit that references this issue on Jun 2, 2022
  7. added a commit that references this issue on Sep 4, 2022
  8. added a commit that references this issue on Nov 14, 2023
  9. added a commit that references this issue on Dec 4, 2023
  10. 41 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions