Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Reconsider arguments passed to get_endpoint_args_for_item_schema() #1135

Description

@danielbachhuber

In aba6bef, @joehoyle added $add_required_flag = true argument to get_endpoint_args_for_item_schema(). This feels a little bit unglamorous.

We discussed a bit and came up with two options:

  • get_endpoint_args_for_item_schema( array( ‘add_required_flag’ => true ) )
  • get_create_endpoint_args() and get_update_endpoint_args()

The latter feels cleaner.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions