Figure out how to make admin functions available to endpoints as they need them #1686

Activity

1. danielbachhuber

   added

   Discussion

   on Oct 23, 2015
2. danielbachhuber

   added this to the 2.0 milestone on Oct 23, 2015
3. joehoyle commented on Oct 27, 2015

   

   joehoyle

   on Oct 27, 2015

   Member

   More actions

   Areas where we current need the admin functions loaded:

   • Anything using page templates
   • Anything using wp_generate_attachment_metadata (e.g. media endpoints)
   • Use of get_editable_roles in the users controller

   Currently the Core unit tests library loads admin.php which is why we didn't catch any of the breakage in unit tests (see https://core.trac.wordpress.org/browser/trunk/tests/phpunit/includes/testcase-xmlrpc.php). I'm not sure of the Core stance on what is loaded, as it's a monolithic test suite run testing everything, they don't load typically any different contexts, presumably meaning fatals can sneak through.

   I don't think Core is likely to change that, as they'd need to run a bunch of different contexts. Instead, we should probably require files in the REST API as we need them (e.g. for wp_generate_attachment_metadata)
4. rachelbaker

   closed this as completedon Oct 31, 2015