Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Return post data from post delete endpoint - #627

Closed
rmccue wants to merge 1 commit into
developfrom
two-return-on-delete
Closed

rmccue wants to merge 1 commit into
developfrom
two-return-on-delete

Conversation

@rmccue

@rmccue rmccue commented Nov 21, 2014

Copy link
Copy Markdown
Member

Fixes #618.

@rmccue rmccue added this to the 2.0 milestone Nov 21, 2014

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone disagree with this one? Could theoretically interfere with a custom status of deleted. We could alternatively indicate this some other way.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gone :)

delete would closer fit the existing naming pattern for statuses.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My other thought was using null, or setting the ID to null. These don't interfere with custom statuses at all, which is nice, but setting the value to null might drop some clients back to default handling for the field (we say to treat it as a draft if you don't get/understand the field), while changing the ID seems like it's removing important information.

@rmccue rmccue added the Review label Nov 21, 2014
@rmccue

rmccue commented Nov 21, 2014

Copy link
Copy Markdown
Member Author

@WP-API/amigos #reviewmerge

@rmccue rmccue removed the Review label Nov 27, 2014
@rachelbaker

Copy link
Copy Markdown
Member

PR needs a refresh for new Posts Controller, and status should be changed to 'delete'. @rmccue mind fixing up this PR?

@rmccue

rmccue commented Mar 30, 2015

Copy link
Copy Markdown
Member Author

This one's on me, sorry. Will fix up ASAP.

@rmccue

rmccue commented Mar 30, 2015

Copy link
Copy Markdown
Member Author

(Also needs unification with #789)

@rmccue rmccue modified the milestones: 2.0 Beta 1, 2.0 Mar 31, 2015
@nacin

nacin commented Apr 8, 2015

Copy link
Copy Markdown

What needs discussion here?

@danielbachhuber

Copy link
Copy Markdown
Member

What needs discussion here?

#789

@rachelbaker

Copy link
Copy Markdown
Member

Punting to Beta 2.

@rachelbaker rachelbaker modified the milestones: 2.0 Beta 2, 2.0 Beta 1 Apr 15, 2015
@danielbachhuber

Copy link
Copy Markdown
Member

Handling in #1224

@danielbachhuber
danielbachhuber deleted the two-return-on-delete branch May 8, 2015 22:14
@danielbachhuber danielbachhuber removed this from the 2.0 Beta 2 milestone May 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete requests shouldn't return response with message body

4 participants