binaryen fails to build from source with LTO (link time optimization) enabled #5946

Activity

1. kripken commented on Sep 18, 2023

   

   kripken

   on Sep 18, 2023

   Last edited by kripken

   Member

   More actions

   Would it be possible to build there with -DBUILD_LLVM_DWARF=OFF? That would disable using this third-party code, which is only used for Binaryen's partial DWARF support (edit: because it's partial, I don't think many people actually depend on it. we don't build it into binaryen.js for example).
2. apoleon commented on Sep 18, 2023

   

   apoleon

   on Sep 18, 2023

   ContributorAuthor

   More actions

   Hi,
   then I get another error because Allocator.h is part of the disabled llvm-project directory

   In file included from /<<PKGBUILDDIR>>/src/support/suffix_tree.cpp:16:
   /<<PKGBUILDDIR>>/src/support/suffix_tree.h:38:10: fatal error: llvm/Support/Allocator.h: No such file or directory
      38 | #include "llvm/Support/Allocator.h"
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
   
3. kripken commented on Sep 18, 2023

   

   kripken

   on Sep 18, 2023

   Member

   More actions

   Hmm, looks related to @ashleynh's work on the suffix tree. Building just that without LLVM errors it seems. Looks like we don't have a flag to disable the suffix tree, and instead we manually disable it in binaryen.js (emscripten) builds, which do not build LLVM:

   binaryen/src/support/CMakeLists.txt

   Lines 18 to 30 in 003a6ff

   	# The below condition is intended for removal once the suffix_tree and
   	# suffix_tree_node source files no longer depend on LLVM code in the
   	# third_party folder
   	if(EMSCRIPTEN)
   	add_library(support OBJECT ${support_SOURCES})
   	else()
   	set(support_with_suffix_tree_SOURCES
   	suffix_tree.cpp
   	suffix_tree_node.cpp
   	${support_SOURCES}
   	)
   	add_library(support OBJECT ${support_with_suffix_tree_SOURCES})
   	endif()

   Perhaps we should add such a flag? Another option might be to find a workaround in that source file. I'm not sure how to do that, though, since LTO shouldn't affect compile-time errors... so that error is odd. But @apoleon , does this patch fix things for you?

   diff --git a/third_party/llvm-project/include/llvm/ADT/edit_distance.h b/third_party/llvm-project/include/llvm/ADT/edit_distance.h
   index 4f5134008..784547108 100644
   --- a/third_party/llvm-project/include/llvm/ADT/edit_distance.h
   +++ b/third_party/llvm-project/include/llvm/ADT/edit_distance.h
   @@ -19,6 +19,11 @@
    #include <algorithm>
    #include <memory>
    
   +// XXX BINARYEN avoid a compiler warning here
   +//     https://github.com/WebAssembly/binaryen/issues/5946
   +#pragma GCC diagnostic push
   +#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
   +
    namespace llvm {
    
    /// Determine the edit distance between two sequences.
   @@ -99,4 +104,7 @@ unsigned ComputeEditDistance(ArrayRef<T> FromArray, ArrayRef<T> ToArray,
    
    } // End llvm namespace
    
   +// XXX BINARYEN
   +#pragma GCC diagnostic pop
   +
    #endif

   If it works then it might be the quickest fix here.
4. apoleon commented on Sep 18, 2023

   

   apoleon

   on Sep 18, 2023

   ContributorAuthor

   More actions

   The patch didn't make a difference for me. I still get the same error. But when I set the ENABLE_WERROR flag in CMakeLists to OFF instead, it works. Maybe there is a better solution but as a quick workaround it already helps.

   👍React with 👍3Reacted by Alon Zakai, Jérémy Lal and Gulg
5. kripken

   added a commit that references this issue on Oct 28, 2024

   Fix Apline compile error on uninitialized value (#7035)

   ...

   e3eaeef
6. rathann commented on Feb 26, 2025

   

   rathann

   on Feb 26, 2025

   Contributor

   More actions

   I suggest building with -DENABLE_WERROR=OFF instead. We do that on Fedora.
7. tlively commented on Mar 3, 2025

   

   tlively

   on Mar 3, 2025

   Member

   More actions

   Closing this because turning Werror off is pretty much the only correct solution in situations like this.
8. tlively

   closed this as completedon Mar 3, 2025
9. GulgDev commented on Apr 9, 2025

   

   GulgDev

   on Apr 9, 2025

   Contributor

   More actions

   I get this error when building on Windows like this:

   cmake . -DENABLE_WERROR=OFF
   make
   
10. tlively commented on Apr 9, 2025

    

    tlively

    on Apr 9, 2025

    Member

    More actions

    @GulgDev, can you open a new issue with details about your build config and the error you're getting?