Repository navigation
Fix table.init text format parsing - #7654
Merged
Merged
Conversation
osa1
marked this pull request as draft
June 13, 2025 10:54
osa1
marked this pull request as ready for review
June 13, 2025 11:20
osa1
commented
Jun 13, 2025
tlively
reviewed
Jun 15, 2025
Member
|
It would also be good to update the comment here as part of this. |
Contributor
Author
Done. With this change we're able to parse |
tlively
reviewed
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
table.inittext format has two forms:table.init tableidx elemidxtable.init elemidx(tableidxis implicitly 0)Because the optional
tableidxis not the last (second) argument, we have to parse one or two immediate arguments, and depending on how many we parsed decide which one iselemidx.Currently the code assumes first immediate argument is always a table, which does not handle the second form.
Before this PR,
wasm-shellfails to parse this functions in spec tests: https://github.com/WebAssembly/testsuite/blob/e05365077e13a1d86ffe77acfb1a835b7aa78422/bulk.wast#L207-L211After the PR we're able to parse it, but we still can't parse the whole file, because of other issues.
Error when parsing
bulk.wast, before this PR:After this PR:
(The new error is about
elem.drop, which we don't support yet, see #7209)