Repository navigation
Remove constants orphaned by #4059 and unused proxy env var names - #4675
Merged
nikola-jokic merged 1 commit intoSep 22, 2026
Conversation
…unused proxy env var names
Okabe-Junya
marked this pull request as ready for review
September 22, 2026 07:05
Okabe-Junya
requested review from
a team,
Steve-Glass,
mumoshu,
nikola-jokic,
rentziass and
toast-gear
as code owners
September 22, 2026 07:05
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
This pull request removes unused constants and aligns proxy environment variable tests with production literals.
Changes:
- Replaces proxy constant references with literal names in tests.
- Removes unused proxy and
ReasonTooManyPodFailuresconstants.
| File | Changes |
|---|---|
controllers/actions.github.com/ephemeralrunner_controller_test.go |
Uses literal proxy environment variable names. |
controllers/actions.github.com/constants.go |
Removes orphaned constants. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nikola-jokic
approved these changes
Sep 22, 2026
Okabe-Junya
deleted the
Okabe-Junya/refactor/remove-orphaned-constants
branch
September 22, 2026 15:32
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SSIA (general house-keeping)
Why
#4059 replaced the "too many pod failures -> mark failed" branch with the backoff/maxFailures recreate mechanism and left the
ReasonTooManyPodFailuresreason constant behind with no remaining references.The proxy env var name constants were never referenced by production code, which sets these env vars from string literals directly, so the test references were switched to the same literals instead of introducing the constants into production code.