Supporting Node.js 14 and 16 LTS as the runtime of JavaScript action

Describe the enhancement

Node.js v14.15.0 has been released and the 14.x release line now moves into Active LTS. Can the GitHub Actions runner support it as the runtime of a JavaScript (TypeScript) action? Is there a roadmap for this?

Code Snippet

Today, we can set node12 to runs.using.

runs:
  using: 'node12'
  main: 'main.js'

Can we set node14 (or node16) as follows?

runs:
  using: 'node14'
  main: 'main.js'

Additional information

https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions

We also need to update the documentation when node14 is available.

Looks like this is not easy 😭

runner/src/Runner.Worker/ActionManifestManager.cs

Lines 454 to 471 in 89a13db

    
           else if (string.Equals(usingToken.Value, "node12", StringComparison.OrdinalIgnoreCase)) 
        
           { 
        
               if (string.IsNullOrEmpty(mainToken?.Value)) 
        
               { 
        
                   throw new ArgumentNullException($"You are using a JavaScript Action but there is not an entry JavaScript file provided in {fileRelativePath}."); 
        
               } 
        
               else 
        
               { 
        
                   return new NodeJSActionExecutionData() 
        
                   { 
        
                       Script = mainToken.Value, 
        
                       Pre = preToken?.Value, 
        
                       InitCondition = preIfToken?.Value ?? "always()", 
        
                       Post = postToken?.Value, 
        
                       CleanupCondition = postIfToken?.Value ?? "always()" 
        
                   }; 
        
               } 
        
           }

Is it done via actions/runner-images#1953 ?

No. This is a problem of the actions/runner.

peaceiris/actions-gh-pages#539

https://github.com/peaceiris/actions-gh-pages/pull/539/checks?check_run_id=1437553870#step:19:20
Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node14' is not supported, use 'docker' or 'node12' instead.')

We need:

compile alpine node14
update the ./external.sh script to download the node14
update C# code and yaml schema to support node14
update documentation

fix: Run with Docker instead of Node.js

Hello,
Is there any update on this or timeline of when to expect this feature?

Thank you,
Milan Zítka

@TingluoHuang

@TingluoHuang I started working on this but I don't have any significant experience with C# so any help or direction would be much appreciated.

Should we just wait for node.js 16 to become LTS and then directly goes to node 16? I don't see too many benefits that go to node 14.

"Active LTS Start: 2021-10-26"
https://nodejs.org/en/about/releases/

not that far away 👍🏻

... we could even start much sooner with using: node14 support in preview to find and flush out any potential issues. no need to wait till October ... we'll just have to turn the crank it least a couple of times. But I do like going straight to 16.

What would be the benefit of supporting node 14? Any features that would be unlocked by using it?

among other things: top-level await, which is great for CLI apps, such as actions written in JS

I like this a lot: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining

Any update on this? I have a few projects I'm looking to update to version 14

The pull-request #1439 will close this and be released in version 2.285.0. (Note: there is no option for node14)

Update action to use native nodejs

Update Node.js from v12 to v16

Update Node.js from v12 to v16 for Apple M1 support (#59)

Update Node.js from v12 to v16

feat: support node.js 16

feat: support node.js 16 (#54)

Navigation Menu

Repository navigation

Supporting Node.js 14 and 16 LTS as the runtime of JavaScript action #772

16 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	else if (string.Equals(usingToken.Value, "node12", StringComparison.OrdinalIgnoreCase))
	{
	if (string.IsNullOrEmpty(mainToken?.Value))
	{
	throw new ArgumentNullException($"You are using a JavaScript Action but there is not an entry JavaScript file provided in {fileRelativePath}.");
	}
	else
	{
	return new NodeJSActionExecutionData()
	{
	Script = mainToken.Value,
	Pre = preToken?.Value,
	InitCondition = preIfToken?.Value ?? "always()",
	Post = postToken?.Value,
	CleanupCondition = postIfToken?.Value ?? "always()"
	};
	}
	}

Supporting Node.js 14 and 16 LTS as the runtime of JavaScript action #772

Description

Activity

viceice commented on Oct 29, 2020

ad-m commented on Nov 22, 2020

peaceiris commented on Nov 22, 2020

TingluoHuang commented on Jan 5, 2021

littlewall commented on Apr 8, 2021

ianwalter commented on May 14, 2021

TingluoHuang commented on Jun 4, 2021

mktcode commented on Jun 4, 2021

bryanmacfarlane commented on Jun 4, 2021

rethab commented on Jun 4, 2021

gr2m commented on Jun 4, 2021

mktcode commented on Jun 4, 2021

16 remaining items

invaderb commented on Nov 13, 2021

peaceiris commented on Dec 1, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions