Repository navigation
Conversation
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
The build is failing. I think that's probably due to the samd-peripherals change. Could you submit a PR to https://github.com/adafruit/samd-peripherals and then update the submodule commit so this will build? THanks.
|
This PR isn't done yet, it lacks a way to configure pull up/down and which edge(s) to count. Do you think it's a good addition on its own? If we decide to support regular pin interrupts, then I could do without this PR myself, even though this is a better fit for me than pin interrupts because a counter is interrupt storm resilient (if we do VM inline callbacks that is, or soft IRQ's as it's called). |
|
I think we need something like this. I wonder though if it could be merged with FrequencyIn which should do edge counting while also tracking a period to determine frequency as well. They both can use the EXTI to generate an event which a TC can count. (Better than using an interrupt because it won't starve the CPU at high frequencies.) What do you think? |
|
Yes I'm aware of the similarity with FrequencyIn, but I need to be able to configure which edges to count on: rise/fall/both. I'm starting to wonder if it would be better to use soft pin interrupts instead if we can just ignore the interrupt if the callback is already on the scheduler stack. This would prevent an interrupt from flooding the stack blocking other soft interrupts. |
|
FrequencyIn is now checked in so please start with that if you still need this functionality. Thanks! |
3 participants
I need pin interrupt support for a project and this is one way of achieving that if we don't end up supporting pin interrupts directly (latency is not a problem for this project since the signal is sent over i2c to a Raspberry Pi).
I have previously wondered if PulseIn (#1072) could be used, but I think a Counter abstraction is a much better fit and has other use cases too. Of course there's that feature creep syndrome and flash is scarce on some boards.
@tannewt was unsure about pull support:
But at least pull up is working on a samd51.
See #1415 for how this Counter can be used with async/await.
This samd-peripherals change is also necessary: https://gist.github.com/notro/2558d4fe1b0699e175c7dc33b9a74d22