Repository navigation
Gain back space in small builds by using lib/libm instead of toolchain libm. - #329
Merged
Merged
Conversation
dhalbert
commented
Oct 15, 2017
dhalbert
commented
Collaborator
- Use lib/libm for small (non-Express builds) to gain back a lot of flash space.
- Add flag INTERNAL_LIBM to mpconfigboard.mk files to signal using lib/libm.
- Fix floating-point warnings in lib/libm
- Turn off -finline-limit, no longer needed due to 1.
- Add explicit flags for SPI_FLASH_FILESYSTEM and INTERNAL_FLASH_FILESYSTEM to mpconfigboard.mk files, so they don't need to know the name of the .c file that implements those. Makefile takes care of checking the flags and including the right files.
Collaborator
Author
|
Didn't start a test build, I think due to my specifying the wrong upstream branch initially. Looks like I can trigger by closing and reopening. Will try that. |
Member
|
I poked Rosie and restarted Travis. Why not use the internal libm for all builds? Seems like consistency might be better. |
…flash space. 2. Add flag INTERNAL_LIBM to mpconfigboard.mk files to signal using lib/libm. 3. Fix floating-point warnings in lib/libm 4. Turn off -finline-limit, no longer needed due to 1. 5. Add explicit flags for SPI_FLASH_FILESYSTEM and INTERNAL_FLASH_FILESYSTEM to mpconfigboard.mk files, so they don't need to know the name of the .c file that implements those. Makefile takes care of checking the flags and including the right files.
dhalbert
force-pushed
the
2.x_issue_325_libm
branch
2 times, most recently
from
October 16, 2017 15:20
01803d3 to
66db657
Compare
dhalbert
force-pushed
the
2.x_issue_325_libm
branch
from
October 16, 2017 16:02
66db657 to
62e3317
Compare
Collaborator
Author
|
@tannewt This is ready to look at again. Using internal libm for all atmel-samd builds now. Removed the pulseio addition on Gemma/Trinket: that will go in a new pull request. |
tannewt
approved these changes
Oct 16, 2017
tannewt
left a comment
tannewt
left a comment
Member
There was a problem hiding this comment.
Looks great! Thanks for finding this! You struck code size gold!
This was referenced Oct 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.