Skip to content

Start of USB host API - #6125

Merged
dhalbert merged 6 commits into
adafruit:mainfrom
tannewt:usb_host
Mar 12, 2022
Merged

Start of USB host API#6125
dhalbert merged 6 commits into
adafruit:mainfrom
tannewt:usb_host

Conversation

@tannewt

@tannewt tannewt commented Mar 8, 2022

Copy link
Copy Markdown
Member

This allows you to list and explore connected USB devices. It
only stubs out the methods to communicate to endpoints. That will
come in a follow up once TinyUSB has it. (It's in progress.)

Related to #5986

tannewt added 4 commits March 7, 2022 18:07
@tannewt
Start of USB host API
83593a1 
This allows you to list and explore connected USB devices. It
only stubs out the methods to communicate to endpoints. That will
come in a follow up once TinyUSB has it. (It's in progress.)

Related to micropython#5986
@tannewt
Add Teensy 4.1 power pin and fix SWD for DEBUG=1
96f5eec
@tannewt
Don't crash on early debug print
91468ed
@tannewt
Fix EVK status led to be inverted
45f9522
@tannewt
tannewt requested a review from jepler March 10, 2022 22:52
@tannewt
tannewt marked this pull request as ready for review March 10, 2022 22:52
@tannewt

tannewt commented Mar 10, 2022

Copy link
Copy Markdown
Member Author

The last build was mostly network failures and one size failure that seems to be unrelated. Please review and I'll likely need to do some tweaks that will lead to another CI run.

dhalbert
dhalbert requested changes Mar 11, 2022
View reviewed changes

@dhalbert dhalbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't verify the i.MX stuff, though I did look it over. That's what your testing is doing.

Mostly some arg validation stuff. You could make these explicitly called-out TODO's if you don't have time.

Thanks for cleaning up and generalizing the debug UART stuff!

Comment thread shared-bindings/usb/core/Device.c Outdated
Comment thread shared-bindings/usb/core/Device.c Outdated
Comment thread shared-bindings/usb/core/Device.c
Comment thread shared-bindings/usb/core/__init__.c Outdated
Comment thread shared-module/usb/core/Device.c Outdated
Comment thread shared-module/usb/core/Device.c
Comment thread shared-module/usb/core/Device.c Outdated
Comment thread shared-module/usb/core/Device.c Outdated
Comment thread shared-module/usb/core/Device.c
@dhalbert

dhalbert commented Mar 11, 2022

Copy link
Copy Markdown
Collaborator

One board is not fitting.

@tannewt

tannewt commented Mar 12, 2022

Copy link
Copy Markdown
Member Author

TinyUSB grew in size:

_usbd_rhport                                                      +1
dcd_mutex_def                                                     +2
dcd_mutex                                                         +4
usbd_int_set                                                     +20
storage_erase_filesystem                                          +8
complex_attr                                                      +2
osal_queue_send.isra.0                                           -16
edpt_dma_start                                                   +36
compile_decorated                                                 -4
mp_obj_exception_attr                                             +4
usbd_edpt_xfer.isra.0                                            +80
compile_atom_expr_normal                                          +4
tusb_hal_nrf_power_event                                          +4
mscd_xfer_cb                                                     +24
mp_qstr_const_attr                                                -4
usb_background                                                   -16
main                                                             +24
mp_qstr_const_pool                                                -8
_usbd_initialized                                                 -1

Total 258461 - 258297                                           +164

@jpconstantineu this disables the traceback module on the bluemicro833. It's new so I figured no code uses it. (Could do watchdog as an alternative.)

dhalbert
dhalbert approved these changes Mar 12, 2022
View reviewed changes

@dhalbert dhalbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert
dhalbert merged commit f13d218 into adafruit:main Mar 12, 2022
@rycwo rycwo mentioned this pull request Apr 11, 2022
Closed
@tannewt tannewt mentioned this pull request May 9, 2022
Closed
@tannewt tannewt mentioned this pull request Jun 28, 2022
Closed
@dhalbert dhalbert mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhalbert dhalbert dhalbert approved these changes
@jepler jepler Awaiting requested review from jepler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tannewt @dhalbert