Repository navigation
Setup default BLE name in dotenv - #6596
Merged
Merged
Conversation
Format: CIRCUITPY_BLE_NAME = My BLE Board - the length is limited to 31 characters - for the NRF version it repeatedly truncates the name if it's too long - the ESP version defaults to "nimble" if the name is too long
tannewt
self-requested a review
July 14, 2022 18:07
tannewt
requested changes
Jul 14, 2022
tannewt
left a comment
tannewt
left a comment
Member
There was a problem hiding this comment.
Thanks for this! Code looks good. Please add documentation of this to docs/environment.rst.
Author
|
Ah I knew I forgot something. Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the default BLE name of a board, for BLE workflow in particular (for example in a classroom setting).
This is only the default name, user code can later redefine the BLE name too.
Use
CIRCUITPY_BLE_NAMEin.env.