Repository navigation
submodules: update tinyusb; remove usb_descriptor; use partial clone for submodules - #7763
Merged
microdev1 merged 3 commits intoMar 21, 2023
Merged
Conversation
microdev1
reviewed
Mar 21, 2023
microdev1
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/usb_descriptorsubmodule.make fetch-submodulesto usegit submodule update --init --filter=blob:none. This does a partial clone of all submodules: all the tree metadata is fetch, but data blobs are fetch only on demand. This is slightly faster and does not have the idiosyncrasies of a shallow clone: non-HEAD checkouts are seamless, all tags are available, etc. Fixes Consider using git "partial clone" #7225.Note that the huge
broadcom/firmwaresubmodule hasshallow = truein .gitmodules, but it never seemed to actually work and force a shallow fetch. I did not remove that.Here is the time difference between various ways of doing the equivalent of
make fetch-submodule. Plain blobless is fastest. (EDIT to include all possibilities). Each one was done on a freshly cloned repo.