Repository navigation
feat(signer-tempo): add Tempo wallet keystore reader - #3936
Merged
Merged
Conversation
stevencartavia
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
April 29, 2026 05:54
Amp-Thread-ID: https://ampcode.com/threads/T-019dd9de-b83a-773b-b26f-75757e391126 Co-authored-by: Amp <[email protected]> # Conflicts: # Cargo.toml
zerosnacks
approved these changes
May 5, 2026
zerosnacks
left a comment
Contributor
There was a problem hiding this comment.
Overall lgtm, pending a second review
mattsse
approved these changes
May 7, 2026
mattsse
left a comment
Member
There was a problem hiding this comment.
LGTM. I pushed the publishability fix so alloy-signer-tempo can be consumed downstream by Foundry; the remaining notes are non-blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
alloy-signer-tempo: a read-only reader for the Tempo wallet keystore (~/.tempo/wallet/keys.toml) that produces aPrivateKeySignerplus optional Keychain-mode metadata.