Skip to content

fix(ci): stabilize main red tests - #3942

Merged
mattsse merged 1 commit into
mainfrom
centaur/fix-main-ci-tests-codeonly
Apr 30, 2026
Merged

fix(ci): stabilize main red tests#3942
mattsse merged 1 commit into
mainfrom
centaur/fix-main-ci-tests-codeonly

Conversation

@decofe

@decofe decofe commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • switch the flaky ENS public resolver tests to https://ethereum.reth.rs/rpc
  • stop exposing reqwest-backed HTTP constructors on wasm32-wasip1
  • make reqwest a non-wasm32-wasip1 dependency in the HTTP/provider/rpc-client crates so the WASI build no longer pulls unsupported Tokio and aws-lc paths

Why

main is currently red in two places:

  • all-features jobs fail because two ENS tests still hit the plain-HTTP ethereum.reth.rs endpoint, which now returns 520
  • wasm-wasi fails while building the alloy package because default reqwest/rustls paths on wasm32-wasip1 pull unsupported Tokio and aws-lc-sys codepaths

Validation

  • cargo fmt --check
  • git diff --check
  • targeted cargo tests were blocked in this sandbox by crates.io 429 Rate limit exceeded responses while resolving dependencies

@grandizzy
grandizzy marked this pull request as ready for review April 30, 2026 07:48
mattsse
mattsse approved these changes Apr 30, 2026
View reviewed changes

@mattsse mattsse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@github-project-automation github-project-automation Bot moved this to Reviewed in Alloy Apr 30, 2026
@mattsse
mattsse merged commit 18425b7 into main Apr 30, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in Alloy Apr 30, 2026
@mattsse
mattsse deleted the centaur/fix-main-ci-tests-codeonly branch April 30, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes
@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner
@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner
@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner
@zerosnacks zerosnacks Awaiting requested review from zerosnacks
@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Alloy
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@decofe @mattsse