Repository navigation
docs(consensus): clarify generic EIP-4844 return doc - #3997
Merged
onbjerg merged 1 commit intoSep 9, 2026
Merged
Conversation
jschnelder
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
May 19, 2026 13:09
onbjerg
approved these changes
Sep 9, 2026
onbjerg
force-pushed
the
consensus-clarify-eip4844-return-doc
branch
from
September 9, 2026 08:27
c812e90 to
47df58a
Compare
onbjerg
enabled auto-merge (squash)
September 9, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The doc comment for
try_into_eip4844incrates/consensus/src/transaction/envelope.rswas too specific and implied the return was tied toTxEip4844, while the actual signature is generic (Result<Signed<Eip4844>, ValueError<Self>>).This mismatch can confuse readers about the API contract.
Solution
Updated the doc comment to describe the return as the EIP-4844 variant in generic terms, matching the method signature and avoiding type-specific wording.
This is a docs-only change with no runtime behavior change.
PR Checklist