Remove the search module's dependency on other feature modules - #1271

What I have done and why
The :feature:search module depended on the :feature:foryou, :feature:bookmarks and :feature:interests modules.

It is bad practice for :feature modules to depend on other feature modules. Common functionality should be abstracted into :core modules and shared between those feature modules. This makes it clear what is unique to a given feature, and what is shared.

With this in mind I have:

• Refactored the SearchScreen composable to accept only a single view model SearchViewModel (it previously required an InterestsViewModel and a BookmarksViewModel).
• Added the functions provided by those other view models into SearchViewModel. I considered adding use cases for these but decided that since there is zero logic involved (they are one-line calls to repository methods) it keeps things simple to just add them directly.
• Moved InterestsItem into :core:ui so it can be shared between the :feature:interests and :feature:search modules.

Fixes #707
Related #810

:feature:search Dependency graph

Before	After