Repository navigation
TestFixtures refactoring - #1515
SimonMarquis wants to merge 7 commits into
Conversation
8f377a3 to
35adf5e
Compare
|
This PR has a lot of conflicts. Do you want to continue and resolve these, @SimonMarquis ? |
|
@keyboardsurfer yes, I'd love to see this integrated in the repository at some point (the initial PoC was on Nov 19, 2022 😅). |
|
Good to hear that you're interested in picking this back up again. @JoseAlcerreca can you chime in on the likelihood of this PR being integrated into main? |
|
Just to add my 2 pence, I am strongly in favour of anything that tidies up our test architecture and TestFixtures seems to do that. |
emartynov
left a comment
emartynov
left a comment
There was a problem hiding this comment.
Super. LGTM. Just a couple of questions came here.
Does that mean "yes", or "maybe"? 😅 |
4 participants
Support for Kotlin TestFixtures on Android modules was added in AGP 8.5.0!
A lot more cleanup could be done, especially on test classes that redefine over and over again topics, newsResources, etc.
This is a new take on this PR:
To close this issue from 2022:
The main changes are split by commits:
enableTestFixturesKotlinSupportflag:core:data-test,:sync:testand:core:datastore-testhave been merged as testFixtures sourceSet of their respective module.:core:testingcontent has been migrated when possible to already existing modules.:sync:workhas been move to it's parent:syncmodule that was previously empty.android.experimental.enableTestFixturesKotlinSupportto promote from experimental?