Repository navigation
Allow setting preferred devices to AudioTrack #135
Description
Use case description
AudioTrack is useful to apps for multiple reasons
- exposes detailed state of the audio subsystem, such as offload.
- allows changing the preferred devices
Proposed solution
Make AudioTrack accessible in DefaultAudioSink.
Alternatives considered
Fully expose all interesting bits of AudioSink via accessors in DefaultAudioSink or Player.Listener events.
Activity
tonihei commentedon Aug 2, 2022
Besides
isAudioOffloadEnabled, which bits of information would you like to expose exactly? It's not quite clear to me what these interesting bits ofAudioSinkare. We are unlikely to expose theAudioTrackdirectly as it breaks the encapsulation and may cause unexpected side effects if someone changesAudioTrackin any way outside ofDefaultAudioSink.yschimke commentedon Aug 2, 2022
I think just the preferred devices.
But more generally once you get to a point that you care about the state of the AudioTrack, it's awkward to do anything without copying and pasting DefaultAudioSink for even the most minor of changes.
Feel free to close.
tonihei commentedon Aug 2, 2022
Thanks, I'll change it to an enhancement tracking how users can specify preferred devices for audio playback.
[-]Access to AudioTrack via DefaultAudioSink[/-][+]Allow setting preferred devices to AudioTrack [/+]Add setPreferredAudioDevice method to ExoPlayer
Add setPreferredAudioDevice method to ExoPlayer
Add setPreferredAudioDevice method to ExoPlayer
Add setPreferredAudioDevice method to ExoPlayer
Chore/bump exo 2.18.2 (#66)
Chore/merge canary in (#74)
christosts commentedon Feb 2, 2024
@tonihei this is completed, right?
yschimke commentedon Feb 2, 2024
I think yes via other APIs.