Repository navigation
Testing: inconsistencies between Location and SpyLocation #27059
Description
🐞 bug report
Affected Package
The issue is caused by package @angular/common/testingIs this a regression?
No, I think it never worked.Description
- The
normalizemethod in theLocationclass works correctly, when in theSpyLocationclass it always returnsnull(https://github.com/angular/angular/blob/7.0.3/packages/common/testing/src/location_mock.ts#L120) - The
subscribemethod in theLocationclass is fired only onpopstateevent (https://github.com/angular/angular/blob/7.0.3/packages/common/src/location/location.ts#L140), when in theSpyLocationclass is fired on each navigation (https://github.com/angular/angular/blob/7.0.3/packages/common/testing/src/location_mock.ts#L115)
🔥 Exception or Error
The different behavior breaks the tests.
🌍 Your Environment
Angular Version:
Angular CLI: 7.0.1
Node: 8.11.1
OS: win32 x64
Angular: 7.0.0
Anything else relevant?
There are unresolved issues related to these inconsistencies: #10963 and https://stackoverflow.com/questions/47484775/location-class-from-angular-common-doesnt-work-in-unit-tests
Thanks!
Activity
yggg commentedon Jun 29, 2019
Also,
SpyLocation.pathmethod always returns path with the fragment whenLocationhas anincludeHashparameter which is false by default.ondrasej commentedon Jul 25, 2020
Also,
SpyLocation.path()returns only the path, but not the query.Location.path()returns the path and the query.7 remaining items
fix(router): eagerly update internal state on browser-triggered navig…
fix(router): eagerly update internal state on browser-triggered navig…
angular-automatic-lock-bot commentedon Oct 3, 2021
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.