Router Resolve<T> should have official support for UrlTree based redirection

🚀 feature request

Relevant Package

Description

I see that in the docs it is recommended to do the following to cancel a navigation event in a Resolve<T> route data resolver.

resolve(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): Observable<Crisis> | Observable<never> {
    let id = route.paramMap.get('id');
 
    return this.cs.getCrisis(id).pipe(
      take(1),
      mergeMap(crisis => {
        if (crisis) {
          return of(crisis);
        } else { // id not found
          this.router.navigate(['/crisis-center']);
          return EMPTY;
        }
      })
    );
  }

While this does work it generates a pretty gnarly NavigationCancel event that basically says 'You broke my internal state':

NavigationCancel {id: 5, url: "/crisis-center/4444", reason: "Navigation ID 5 is not equal to the current navigation id 6"}
id: 5
reason: "Navigation ID 5 is not equal to the current navigation id 6"
url: "/crisis-center/4444"

This is because we have overlapping navigation events, and the original navigation is cancelled because we essentially triggered the router's panic mode.

Describe the solution you'd like

Angular 7.1 introduced the option of returning a UrlTree from a canActivate, and I think something similar should be added to Resolve<T> for feature parity.

A Resolve may fail for many reasons, but we should have a clean option to redirect within the resolver - especially in cases where it is impossible to know the final destination until you've attempted to get the data.

I think perhaps the signature of resolve needs to become something like :

 resolve(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): Observable<T | UrlTree> | Promise<T | UrlTree> | T | UrlTree;

Describe alternatives you've considered

Yes, delving into the code showed me that I could throw an error that satisfies the isNavigationCancelingError() type-guard and not only would it give me a nicer NavigationCancel event it would also allow me to pass a url: UrlTree parameter which will then be navigated to on my behalf.

      throw { ngNavigationCancelingError: true, url: this.router.createUrlTree(newUrl) };

While this actually works quite well - and gives the following 'nice' event it isn't really supported since I have to use the magic internal property name - and also not every reason for aborting a Resolve is an error condition.

NavigationCancel {id: 11, url: "/account/orders/latest", reason: undefined}
id: 11
reason: undefined
url: "/account/orders/latest"

The other alternative is what is suggested in the docs, but the error (Navigation ID 5 is not equal to the current navigation id 6) from doing that just makes it look like something is broken.

I think the mechanics of this are basically already there, expecially with the new functionality in 7.1 to handle a UrlTree. There is also plenty of need for such a feature on Stackoverflow..

Agreed, this should be added as a feature. I'll assign to myself, but I know I won't be able to get to this until some time after version 8 is finalized (probably next month). If anyone in the community would like to pick this up, that would be great. It could be modeled on the changes we did to implement this feature in Guards (#26521 and #26478).

Any news ?

Angular 7.1 introduced the option of returning a UrlTree from a canActivate, and I think something similar should be added to Resolve for feature parity.

Returning an UrlTree instead of the actual data will only cause confusion. I think that the best approach would be to improve the router specific error handler so that it can do more things.

TL;DR: You can use ExtraOptions.errorHandler to perform these redirects.

We can either replace it with a proper ErrorHandler class provided via dependency injection, just like for the global ErrorHandler or, at least, we could provide the Router service instance to the router error handler function, not just the error, and it will allow you to do something like this:

const ROUTER_CONFIG: ExtraOptions = {
  errorHandler: (err: unknown, router: Router): any => {
    if (err instanceof AccessDeniedError) {
      router.navigateByUrl(PAGE_URL.ACCESS_DENIED);
    } else if (err instanceof PageNotFoundError) {
      router.navigateByUrl(PAGE_URL.PAGE_NOT_FOUND);
    } else if (err instanceof HttpErrorResponse) {
      // verify the response code and do something..
    } else {
      throw err;
    }
  }
}

@NgModule({
  exports: [RouterModule],
  imports: [RouterModule.forRoot(ROUTES, ROUTER_CONFIG)],
})
export class AppRoutingModule { }

This last option would be very easy to implement, you just add this (an instance of Router) to t.resolve(this.errorHandler(e)); in:

https://github.com/angular/angular/blob/10.0.0-rc.0/packages/router/src/router.ts#L803-L811

~~If we get a 👍 from the Angular Core maintainers, I'll update the code + write the tests.~~

L.E.

It looks like there is just one test for custom error handlers, which doesn't cover much

https://github.com/angular/angular/blob/10.0.0-rc.0/packages/router/test/integration.spec.ts#L1346-L1361

And looking through the history (#25740) I found that the current errorHandler code has been inherited from the old Promise-based router, and you also couldn't to much with it in the previous version. Maybe I'm missing something, but in the current state, the errorHandler seems to be very limited. Any ideas what you could do with it? If a redirect could be performed?

L.E.2

It turns out that you can actually use this, if you pass the error handler as a normal function, not an arrow function, so the above code works if you just change the definition to something like this:

export function appRoutingErrorHandler(this: Router, err: unknown): any {
  // ...
}
const ROUTER_CONFIG: ExtraOptions = {
  errorHandler: appRoutingErrorHandler,
}

I think that this part should be documented, and maybe an example could be given. I'll look into this in the next week or so.

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

This would be possible after introducing a RedirectCommand (#45023). Resolvers that return the Router's RedirectCommand would be assumed to be distinctly indicating a redirect rather than resolved data.

Any update on that?

feat(router): Allow resolvers to return `RedirectCommand`

feat(router): Allow resolvers to return `RedirectCommand` (angular#54556

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Navigation Menu

Repository navigation

Router Resolve<T> should have official support for UrlTree based redirection #29089

🚀 feature request

Relevant Package

Description

Describe the solution you'd like

Describe alternatives you've considered

6 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Router Resolve<T> should have official support for UrlTree based redirection #29089

Description

🚀 feature request

Relevant Package

Description

Describe the solution you'd like

Describe alternatives you've considered

Activity

jasonaden commented on Apr 4, 2019

euskadi31 commented on Jun 7, 2019

SchnWalter commented on May 29, 2020

angular-robot commented on Jun 4, 2021

atscott commented on Jun 22, 2022

6 remaining items

Adamicov commented on Jul 28, 2023

angular-automatic-lock-bot commented on Apr 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions