Repository navigation
[Dart] Transformers handling of Input, Output, HostBinding and HostListener #4407
Description
As of today the Input, Output, HostBinding and HostListener are added to the propMetadata property of a RegisteredType.
As a result Property does not generate setters and Event does not generate getters.
I think that a best way to handle them would be:
- to merge the info into the metadata
- to not record the property decorator on the
RegisteredType
@Component({})
class Cmp {
@Input() pa;
@Input('pb-name') pb;
@Output() ea;
@Output('EventName') eb;
@HostBinding('hpa') toHost;
@HostListener('event', [exp1, exp2]) handleEvent(a1, a2) { ... }
}
// should lead to the same metadata as:
@Component({
properties: ['pa', 'pb: pb-name'],
events: ['ea', 'eb: EventName'],
host: {
'hpa': 'toHost',
'(event)': 'handleEvent(exp1, exp2)'
}
})
class Cmp {}/cc @vsavkin
Activity
kegluneq commentedon Sep 29, 2015
This approach makes sense to me, however I do not have the cycles to make it happen currently.
In addition, the work done on the compiler-integration branch will obsolete any effort put into this now, so I recommend we wait until that has landed to make these sugar-y kind of changes.
yjbanov commentedon Oct 1, 2015
We should also wait until the
Eventrename is done, and we should postpone the rename till after pre-compilation lands on master.yjbanov commentedon Oct 1, 2015
This is blocked by #3605
[-][Dart] Transformers handling of Property, Event, HostBinding and HostListener[/-][+][Dart] Transformers handling of Input, Output, HostBinding and HostListener[/+]tejainece commentedon Nov 11, 2015
Any updates on this?
angular-automatic-lock-bot commentedon Sep 8, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.