Repository navigation
Breaking undocumented change from Angular 13 to 14 in custom PreloadingStrategy. "preload"-method is called despite a set canLoad-guard. #47003
Description
Which @angular/* package(s) are the source of the bug?
core, router
Is this a regression?
Yes
Description
In Angular 13.3.10 the "preload"-Method in a custom PreloadingStrategy is not called for routes with a set canLoad-guard.
https://stackblitz.com/edit/angular-ivy-wf131m?file=src/app/app-routing.module.ts
This is also mentioned in the documentation: https://angular.io/guide/router-tutorial-toh#canload-blocks-preload
In Angular 14.0.0 this behaviour changed. The "preload"-method is called despite a set canLoad-guard. This change was not mentioned in the changelog and is the opposite of what is written in the documentation. Is this an intended change?
https://stackblitz.com/edit/angular-ivy-nabdle?file=src/app/app-routing.module.ts
Please provide a link to a minimal reproduction of the bug
https://stackblitz.com/edit/angular-ivy-nabdle?file=src/app/app-routing.module.ts
Please provide the exception or error you saw
The "preload"-method is called despite a set canLoad-guard in angular 14.
Please provide the environment you discovered this bug in (run ng version)
No response
Anything else?
No response
Activity
atscott commentedon Aug 1, 2022
Version 14 introduced the
loadComponentfor routes, which is not blocked bycanLoadguards. This is why thepreloadmethod is still called. That said, theloadChildrenis not called if there is acanLoadguard so I would not consider this a breaking change.The documentation could use an update and I will also adjust the code to not call the
preloadmethod in cases where there is acanLoadand noloadComponent. In this scenario, there is no need to call thepreloadmethod since nothing will be done with the result.fix(router): Do not call preload method when not necessary
5te1n commentedon Aug 2, 2022
@atscott Thank you. That sounds like a good solution. In my case, I wanted to preload the modules only after the user logged in. So I removed the canLoad-guards after the login and called Router.preload() manually.
fix(router): Do not call preload method when not necessary (#47007)
angular-automatic-lock-bot commentedon Sep 2, 2022
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.