Allow Asynchronous APP_INITIALIAZER #5929

Activity

1. jteplitz

   added

   featureLabel used to distinguish feature request from other issuesLabel used to distinguish feature request from other issues

   P2: required

   effort1: hours

   state: Needs Design

   on Dec 15, 2015
2. vsavkin commented on Dec 16, 2015

   

   vsavkin

   on Dec 16, 2015

   Contributor

   More actions

   Option 1

   We can support it as follows:

   function funcReturningAPromise:Promise() {...}
   
   platform(MY_PLATFORM).
     asyncApplication(
       () => [], 
       [provide(APP_INITIALIZER, {useFactory: () => funcReturningAPromise})]).
     then(appRef => ...);
   

   • Angular will check the results of app initializers, collect all the promises, and wait for them to be resolved before resolving the application ref promise.
   • Angular will throw if an initializer returned a promise when application was used instead of asyncApplication.

   Option 2

   Another option would be to do the following:

   function funcReturningAPromise:Promise() {...}
   
   let appRef = platform(MY_PLATFORM).application([platform(APP_INITIALIZER, {useFactory: () => funcReturningAPromise})]);
   appRef.get(APP_INITIALIZERS_COMPLETED).then(_ => {
   
   });
   

   This would work with both application and asyncApplication.

   I think Option 1 is cleaner.
3. jteplitz commented on Dec 16, 2015

   

   jteplitz

   on Dec 16, 2015

   ContributorAuthor

   More actions

   I also think Option 1 is cleaner. I'm happy to go ahead and implement it if you want. I think if we do option 1 we should allow people to pass in null as the first argument to asyncApplication as well as a function.
4. 8 remaining items

   Load more
5. jteplitz

   added 5 commits that reference this issue on Jan 13, 2016

   feat(core/application_ref): Allow asyncronous app initializers.

   ...

   This issue will close once commit 8b186fa is merged into the 'master' branch.

   8b186fa
6. mhevery

   closed this as completedin df3074fon Jan 21, 2016
7. angular-automatic-lock-bot commented on Sep 7, 2019

   

   angular-automatic-lock-botbot

   on Sep 7, 2019

   More actions

   This issue has been automatically locked due to inactivity.
   Please file a new issue if you are encountering a similar or related problem.

   Read more about our automatic conversation locking policy.

   _{This action has been performed automatically by a bot.}
8. angular-automatic-lock-bot

   locked and limited conversation to collaborators on Sep 7, 2019