fix(router): should run resolvers for the same route concurrently - #15499

Also waitForMap is called twice in the code base. Could it cause concurrency issue when loading child config (ie if both use the loadChildren) ?

probably yes, so I decided not to use it at all. It's more readable without waitForMap + faster (we don't need to loop 2 times).

May be the second should complete the first and then we do not have to play with timings.

Don't think it's a good idea. Consider such test but without the fix (resolvers run sequentially). resolver1 will never complete because resolver2 will never run (deadlock). So to fail such test we will need to introduce a timeout. Plus we need to add the second should complete the first logic. Sounds like overhead to me.

So to fail such test we will need to introduce a timeout.

Jasmine will timeout by default (you can override the default timeout with a shorter one).

the second should complete the first

should be trivial ?

@vicb updated. it's a little bit more code but it's sync now 😃

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}