Repository navigation
Conversation
|
So there's good news and bad news. 馃憤 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 馃槙 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
vicb
left a comment
There was a problem hiding this comment.
As discussed in #13922 (comment) this does not account for the forward button.
Might be better to fix all in a single PR.
|
@vicb 馃 Is waiting for forward to be fixed really required? Back is used so much more and it looks this was first fixed 6 months ago. Nobody seems too interested in addressing forward. |
042cae1 to
61e7fda
Compare
|
You can preview 61e7fda at https://pr18135-61e7fda.ngbuilds.io/. |
|
Anyone working this? Is this being postponed until the forward button issue #15664 is solved as well and put into a single pull request? |
|
Closing this PR as it's not getting approved as-is. We need to create a new PR to fix both issues. |
|
@jasonaden so are issues still present? |
|
+1 |
yes, still reproducible in 7.2 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
navigation
Rebased from #13922.
Closes #13586