Repository navigation
Conversation
atscott
force-pushed
the
routerStandaloneDirectives
branch
7 times, most recently
from
July 13, 2022 16:53
5304cf4 to
c236d03
Compare
atscott
force-pushed
the
routerStandaloneDirectives
branch
3 times, most recently
from
July 13, 2022 19:28
1cfa424 to
32d4682
Compare
atscott
added
feature
atscott
force-pushed
the
routerStandaloneDirectives
branch
from
July 13, 2022 19:52
32d4682 to
259efe2
Compare
Contributor
Author
atscott
marked this pull request as ready for review
July 13, 2022 22:17
pullapprove
Bot
requested review from
dylhunn,
jessicajaniuk and
pkozlowski-opensource
July 13, 2022 22:17
jessicajaniuk
approved these changes
Jul 13, 2022
jessicajaniuk
left a comment
jessicajaniuk
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
atscott
force-pushed
the
routerStandaloneDirectives
branch
2 times, most recently
from
July 14, 2022 18:04
c68999e to
d532054
Compare
This commit makes the router directives standalone and refactors some of the Router injectables to be `providedIn: 'root'` along with factory functions for initialization.
atscott
force-pushed
the
routerStandaloneDirectives
branch
from
July 14, 2022 18:52
d532054 to
ebabd20
Compare
Contributor
Author
|
TGP after some fixes. Should run regular presubmit as a sanity check |
AndrewKushnir
approved these changes
Jul 14, 2022
AndrewKushnir
approved these changes
Jul 14, 2022
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api, size-tracking
Contributor
Author
Contributor
|
This PR was merged into the repository by commit 26ea976. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits