Repository navigation
feat(router): expose resolved route title - #46826
Closed
EmmanuelRoux wants to merge 1 commit into
Closed
EmmanuelRoux wants to merge 1 commit into
EmmanuelRoux wants to merge 1 commit into
Conversation
EmmanuelRoux
force-pushed
the
expose-route-title
branch
2 times, most recently
from
July 13, 2022 18:14
93e1afa to
5b71be0
Compare
atscott
requested changes
Jul 13, 2022
AndrewKushnir
removed their request for review
July 13, 2022 19:27
EmmanuelRoux
commented
Jul 15, 2022
EmmanuelRoux
force-pushed
the
expose-route-title
branch
from
July 16, 2022 14:10
23f4358 to
4c6fc59
Compare
EmmanuelRoux
changed the title
EmmanuelRoux
force-pushed
the
expose-route-title
branch
from
July 16, 2022 14:21
4c6fc59 to
aa9153e
Compare
atscott
requested changes
Jul 18, 2022
atscott
left a comment
atscott
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the changes. Before we merge, could you please squash the commits into one?
atscott
reviewed
Jul 18, 2022
EmmanuelRoux
force-pushed
the
expose-route-title
branch
from
July 18, 2022 18:30
aa9153e to
5522583
Compare
atscott
approved these changes
Jul 18, 2022
atscott
approved these changes
Jul 18, 2022
atscott
left a comment
atscott
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
atscott
added
the
action: global presubmit
AndrewKushnir
approved these changes
Jul 18, 2022
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
jessicajaniuk
approved these changes
Jul 18, 2022
jessicajaniuk
left a comment
jessicajaniuk
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
atscott
requested changes
Jul 18, 2022
EmmanuelRoux
force-pushed
the
expose-route-title
branch
from
July 18, 2022 22:27
5522583 to
0b237c0
Compare
atscott
approved these changes
Jul 18, 2022
Expose resolved route title from ActivatedRoute and ActivatedRouteSnapshot
EmmanuelRoux
force-pushed
the
expose-route-title
branch
from
July 18, 2022 22:46
0b237c0 to
0a79dea
Compare
jessicajaniuk
removed request for
AndrewKushnir,
alxhub,
dylhunn and
jessicajaniuk
July 18, 2022 22:47
Contributor
|
caretaker note: This will require patching cl/462221001 when syncing. |
atscott
removed
the
action: global presubmit
Contributor
|
green TGP with patches |
atscott
added
the
merge: caretaker note
Contributor
|
merge assistance:
|
Member
|
This PR was merged into the repository by commit 10289f1. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #46825
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #46825
What is the new behavior?
Since Angular 14, router has a new mechanism to update page title from route config. The route can either be a static string or resolved in the same way as
resolvedata.But the resolved route title is not exposed and inaccessible from client application (it seems the title is actually stored in the resolved
Data, but using a privateSymbolso it can't be accessed properly).This PR adds a new
titleproperty onActivatedRouteandActivatedRouteSnapshot.Does this PR introduce a breaking change?
Other information