Repository navigation
Conversation
atscott
added
breaking changes
target: major
pullapprove
Bot
requested review from
AndrewKushnir,
alxhub and
pkozlowski-opensource
October 4, 2022 17:14
The `relativeLinkResolution` is no longer supported. The only behavior now is the correct behavior. BREAKING CHANGE: `relativeLinkResolution` is no longer configurable in the Router. This option was used as a means to opt out of a bug fix.
atscott
force-pushed
the
removeRelativeLinkResolution
branch
from
October 4, 2022 17:20
07f2a4a to
34e9f1e
Compare
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a quick question regarding InternalExtraOptions.
AndrewKushnir
approved these changes
Oct 4, 2022
AndrewKushnir
approved these changes
Oct 4, 2022
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
pkozlowski-opensource
approved these changes
Oct 5, 2022
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
pkozlowski-opensource
removed their request for review
October 5, 2022 06:58
atscott
added
action: merge
Contributor
Author
|
caretaker note: this requires an update to the patch (cl/478846313) |
Contributor
|
This PR was merged into the repository by commit 7b89d95. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
relativeLinkResolutionis no longer supported. The only behavior now is the correct behavior.BREAKING CHANGE:
relativeLinkResolutionis no longer configurable in the Router. This option was used as a means to opt out of a bug fix.