Skip to content

[Python] Change MSVC version for wheel builds - #47357

Closed
pitrou wants to merge 1 commit into
apache:mainfrom
pitrou:fill-null-windows2
Closed

[Python] Change MSVC version for wheel builds#47357
pitrou wants to merge 1 commit into
apache:mainfrom
pitrou:fill-null-windows2

Conversation

@pitrou

@pitrou pitrou commented Aug 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

For GH-47234: try to see if bumping the compiler version would change things

@pitrou

pitrou commented Aug 18, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheelcp313*

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou force-pushed the fill-null-windows2 branch from 9111f0c to 70165ad Compare August 18, 2025 09:09
@pitrou

pitrou commented Aug 18, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheelcp313*

@github-actions

github-actions Bot commented Aug 18, 2025

Copy link
Copy Markdown

Revision: 70165ad3a8ffd796b7f029c1fe6f9c38c934c41f

Submitted crossbow builds: ursacomputing/crossbow @ actions-364548feea

Task Status
wheel-macos-monterey-cp313-cp313-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64 GitHub Actions
wheel-windows-cp313-cp313-amd64 GitHub Actions
wheel-windows-cp313-cp313t-amd64 GitHub Actions

@pitrou

pitrou commented Aug 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

The vcpkg build phase fails with the given VS compiler version, so I'm not sure how to move forward here. Will probably close.

Edit: rebuilding the deps using vcpkg also failed in #47360, despite no other changes being made. So we must first fix the issue with our vcpkg build chain.

@pitrou pitrou changed the title [Python] Bump Windows SDK version for wheel builds [Python] Change MSVC version for wheel builds Aug 18, 2025
@pitrou pitrou mentioned this pull request Aug 18, 2025
Closed
@AlenkaF AlenkaF mentioned this pull request Aug 26, 2025
Closed
@pitrou
pitrou force-pushed the fill-null-windows2 branch from 70165ad to 9181d28 Compare September 8, 2025 14:22
@pitrou

pitrou commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheel-manylinux-2-28-cp313-cp313-amd64

@pitrou
pitrou force-pushed the fill-null-windows2 branch from 9181d28 to 33e6ffc Compare September 8, 2025 14:25
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou

pitrou commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown

Revision: 33e6ffc

Submitted crossbow builds: ursacomputing/crossbow @ actions-78378c0323

Task Status
wheel-windows-cp313-cp313-amd64 GitHub Actions

@pitrou

pitrou commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

Hmm, this is installing an earlier version of MSVC (19.42.34444.0) than the latest rebuild of our Docker image (19.44.35215.0 here). So let's close this PR.

@pitrou pitrou closed this Sep 8, 2025
@pitrou
pitrou deleted the fill-null-windows2 branch September 8, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlenkaF AlenkaF Awaiting requested review from AlenkaF AlenkaF will be requested when the pull request is marked ready for review AlenkaF is a code owner
@raulcd raulcd Awaiting requested review from raulcd raulcd will be requested when the pull request is marked ready for review raulcd is a code owner
@rok rok Awaiting requested review from rok rok will be requested when the pull request is marked ready for review rok is a code owner
@assignUser assignUser Awaiting requested review from assignUser assignUser will be requested when the pull request is marked ready for review assignUser is a code owner
@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane will be requested when the pull request is marked ready for review jonkeane is a code owner
@kou kou Awaiting requested review from kou kou will be requested when the pull request is marked ready for review kou is a code owner

Assignees

No one assigned

Labels

awaiting review Awaiting review Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pitrou