Repository navigation
[CSV-320] Remove Spotbugs Dependency and use exclude-filter instead - #564
Merged
Merged
Conversation
The Spotbugs Dependency introduced by 44b5e6c is toxic. Even marked as optional, using CsvPrinter requires a compile time dependency. Since you do have already an exclude list, I suggest to use this instead of polluting the dependencies.
bjrke
marked this pull request as ready for review
August 21, 2025 08:32
Contributor
|
Thanks for the report! [The addition of spotbugs was not mentioned in the commit message, so it looks like it might have been an accidental commit of a debug experiment.] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Spotbugs Dependency introduced by 44b5e6c is toxic.
Even marked as optional, using CsvPrinter requires a compile time dependency.
Since you do have already an exclude list, I suggest to use this instead of polluting the dependencies.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
https://issues.apache.org/jira/browse/CSV-320
-- I have copilot enabled but it was just suggesting syntax, the idea came from my head
mvn; that'smvnon the command line by itself.-- there is no code change which would require a test