Skip to content

[CSV-320] Remove Spotbugs Dependency and use exclude-filter instead - #564

Merged
aherbert merged 1 commit into
apache:masterfrom
bjrke:master
Aug 21, 2025
Merged

aherbert merged 1 commit into
apache:masterfrom
bjrke:master

Conversation

@bjrke

@bjrke bjrke commented Aug 21, 2025 •

Copy link
Copy Markdown
Contributor

The Spotbugs Dependency introduced by 44b5e6c is toxic.
Even marked as optional, using CsvPrinter requires a compile time dependency.
Since you do have already an exclude list, I suggest to use this instead of polluting the dependencies.

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
    https://issues.apache.org/jira/browse/CSV-320
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request.
    -- I have copilot enabled but it was just suggesting syntax, the idea came from my head
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best-practice.
    -- there is no code change which would require a test
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

The Spotbugs Dependency introduced by 44b5e6c is toxic.
Even marked as optional, using CsvPrinter requires a compile time dependency.
Since you do have already an exclude list, I suggest to use this instead of polluting the dependencies.
@bjrke
bjrke marked this pull request as ready for review August 21, 2025 08:32
@bjrke bjrke changed the title Remove Spotbugs Dependency and use exclude-filter instead [CSV-320] Remove Spotbugs Dependency and use exclude-filter instead Aug 21, 2025
@aherbert
aherbert merged commit 13d10d7 into apache:master Aug 21, 2025
@sebbASF

sebbASF commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

Thanks for the report!

[The addition of spotbugs was not mentioned in the commit message, so it looks like it might have been an accidental commit of a debug experiment.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants